Conversation
Contributor
|
Can one of the admins verify this patch? |
jlebon
reviewed
Sep 24, 2019
| # to make this configurable. | ||
| .PHONY: install | ||
| install: all | ||
| install -m 0755 -D -t $(DESTDIR)/usr/lib/dracut/modules.d/30ignition bin/$(GOARCH)/ignition |
Member
There was a problem hiding this comment.
This is missing ignition-validate, no? We're not shipping it in FCOS, but e.g. it'd be nice to re-use this Makefile in the spec file.
Could also split those two into separate dependent targets (e.g. install-ignition and install-ignition-validate) for the cosa/FCOS local dev case (though really it wouldn't hurt development either if ignition-validate gets overlayed too).
Member
Author
There was a problem hiding this comment.
Updated to ship ignition-validate too.
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler.
jlebon
approved these changes
Sep 25, 2019
jlebon
pushed a commit
to jlebon/ignition
that referenced
this pull request
Mar 16, 2020
Following coreos/ignition-dracut#106 add a default `make install` rule that honors `DESTDIR`. Main motivation is hacking on ignition in a unified way with ostree, ignition-dracut and other projects using coreos-assembler. (Backport of coreos#858)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following coreos/ignition-dracut#106
add a default
make installrule that honorsDESTDIR. Mainmotivation is hacking on ignition in a unified way with ostree,
ignition-dracut and other projects using coreos-assembler.